search

ros / ros_tutorials

Code used in tutorials found on ROS wiki
http://wiki.ros.org/ros_tutorials
787 stars 537 forks source link

Added CI Github action #171

Closed ahcorde closed 2 months ago

ahcorde commented 2 months ago

Do we actually need this? We already have the Rpr jobs running on this repository, and I think it would be better to just stick with that (like we do for the rest of the core packages). Is there a particular reason to add this one?

The job is not active (for now), and this one is for free.

clalancette commented 2 months ago

The job is not active (for now), and this one is for free.

It looks like it is active to me; at least, it seemed to run on this PR, and a couple of other ones that were recently opened. You can see the list of times it ran in https://build.ros2.org/job/Rpr__ros_tutorials__ubuntu_noble_amd64/ .

Mostly I'm just trying to avoid having to maintain this in addition to the Rpr job, and to keep this repository acting like the rest of the core.

ahcorde commented 2 months ago

Sure, closing this then