search

ros / ros_tutorials

Code used in tutorials found on ROS wiki
http://wiki.ros.org/ros_tutorials
805 stars 539 forks source link

I suggest you to change the node names. #20

Closed robotpilot closed 9 years ago

robotpilot commented 9 years ago

$ rosrun turtlesim turtlesim_node $ rosrun turtlesim turtle_teleop_key

$ rosnode list /rosout /teleop_turtle /turtlesim

We usually use the commands above. I think that a beginner confuse the node names, because executable node name and real name are different. The turtlesim package is one of the tutorials for beginner. So, I suggest you to change the node names. How about that?

  1. turtlesim_node VS turtlesim
  2. turtle_teleop_key VS teleop_turtle

ros_tutorials/turtlesim/tutorials/teleop_turtle_key.cpp ...... ros::init(argc, argv, "teleop_turtle"); .....

dirk-thomas commented 9 years ago

Currently the tutorial works with any ROS distro. Changing the naming would require the tutorial to be distro specific.

I am not sure if the small renaming justifies the additional user confusion of having separate tutorials. May be a note in the tutorial mentioning the mapping would be less disruptive.

robotpilot commented 9 years ago

I heard above question from student in a brief question-and-answer period, courses. but, your comment is reasonable opinion. I agree your comment. Thanks dirk-thomas.