search

ros / ros_tutorials

Code used in tutorials found on ROS wiki
http://wiki.ros.org/ros_tutorials
805 stars 539 forks source link

turtlesim should use geometry_msgs/Twist and /cmd_vel #4

Closed chadrockey closed 11 years ago

chadrockey commented 11 years ago

In this tutorial: http://www.ros.org/wiki/ROS/Tutorials/UnderstandingTopics

We seem to suggest that robots should implement their own command message (turtlesim/Velocity). That's not correct, so we should show have turtlesim use /cmd_vel topics and geometry_msgs/Twist as is truly standard. Users often start their own software based on tutorials, so we need to make sure the tutorials follow standard practices.

ahendrix commented 11 years ago

+1

dirk-thomas commented 11 years ago

Either someone provides a complete patch to modify the code and the wiki accordingly or we should just add a note stating that to the existing tutorial.

jihoonl commented 11 years ago

@dirk-thomas I just requested pull request to use Twist msg. Would you check it?

dirk-thomas commented 11 years ago

Pull request #5

dirk-thomas commented 11 years ago

Would you also update the pull request to use the cmd_vel topic?

jihoonl commented 11 years ago

Change pushed.

dirk-thomas commented 11 years ago

The patch has been merged. The Wiki page must be updated but only after a new release is in the public repo.

chadrockey commented 11 years ago

For hydro right? We don't want to risk that someone out there probably depends on that message for their robot.... >:(

On Mon, Feb 4, 2013 at 5:46 PM, Dirk Thomas notifications@github.comwrote:

The patch has been merged. The Wiki page must be updated but only after a new release is in the public repo.

— Reply to this email directly or view it on GitHubhttps://github.com/ros/ros_tutorials/issues/4#issuecomment-13110680.

dirk-thomas commented 11 years ago

Merged #7