remove turtlesim velocity and use Twist msg

[jihoonl]

Turtlesim with Twist message

[chadrockey]

Is geometry_msgs missing from the package.xml and CMakeLists? Otherwise, each substitution looks good. Will the tutorial pages need updated?

+1 to changing "turtle1/command_velocity", etc to "turtle1/cmd_vel"

Does everyone think that allowing the 'Pose' message to continue is fine? Otherwise, we would have to introduce quaternion logic at this point... and pull in tf to do getYawFromQuaternion and getQuaternionFromYaw, etc.

[jihoonl]

I was unsure whether I should use geometry_msgs/Pose. Because Turtlesim/pose was providing both positions and velocity.

[chadrockey]

The standard for Pose + Velocities is nav_msgs/Odometry: http://www.ros.org/doc/api/nav_msgs/html/msg/Odometry.html

However, like I said, orientation is given as a quaternion, so I'm not sure if it's worth including in the tutorials. On the other hand, users have to get used to quaternions eventually. :)

[dirk-thomas]

How is odometry related to that?

[chadrockey]

It's the most standard message we have for a robot reporting its position, orientation, linear velocities, and angular velocities. The turtlesim/Pose message is a simplified nav_msgs/Odometry.

[jihoonl]

@dirk-thomas Both Odometry and turtlesim/Pose are providing position and velocity. @chadrockey I think it is better to leave turtlesim/Pose as it is. Since turtlesim is for very newbies, Odometry may introduce another difficulty to them. So I think it would be better to keep turtlesim simple but lead to next level. I think Odometry can be introduced in the intermediate level tutorial.

[dirk-thomas]

This issue is about the velocity message and topic name. Not about the pose and we should keep it that way.

[dirk-thomas]

Code changes look fine. But turtlesim does not depend on package which provides the Twist msg.

[jihoonl]

package.xml and Cmakelist updated. I wonder why it was compiling without this dependency though.

[jihoonl]

it was not alphabetic order...