Add holonomic motion for turtlesim (foxy)

ros / ros_tutorials

Code used in tutorials found on ROS wiki

http://wiki.ros.org/ros_tutorials

805 stars 540 forks source link

Add holonomic motion for turtlesim (foxy) #98

Closed Tiryoh closed 4 years ago

Tiryoh commented 4 years ago

This PR adds the feature to move the turtle forward by geometry_msgs/Twist message linear.x and linear.y. Related to #93.

dirk-thomas commented 4 years ago

@Tiryoh Please double check the patch. It currently doesn't even compile.

Tiryoh commented 4 years ago

Oops, sorry. I didn't get an error on my laptop, so it maybe an mistake for an operation in git add -p. I'll fix it.

Tiryoh commented 4 years ago

@dirk-thomas I did a git checkout on bd97012 and confirmed that it builds and runs without problems. Could you re-check this PR? ScreenRecord-2020-08-05_20 23 55

dirk-thomas commented 4 years ago

Thanks for the patch. LGTM.

dirk-thomas commented 4 years ago

Cherry-picked to eloquent-devel in 868c0230ee3f32c3e5a59e112f2079f6e3a51019 and dashing-devel in 2db426a6b41600ea4909dcf7ffcb9d01a15d016f.

Tiryoh commented 4 years ago

Thanks!