search

ros / rosconsole

17 stars 61 forks source link

Add timestamp formatting for rosconsole #22

Closed abrzozowski closed 4 years ago

abrzozowski commented 5 years ago

It's Cpp part of formatter Based on PR https://github.com/ros/ros_comm/pull/1458 from ros_comm. Related to the https://github.com/ros/ros_comm/pull/1533 for Python.

dirk-thomas commented 4 years ago

Please retarget the current default branch noetic-devel and rebase your branch.

abrzozowski commented 4 years ago

I rebased my branch on top of ros:melodic-devel. Repository https://github.com/ros/rosconsole doesn't have a noetic-devel branch.

abrzozowski commented 4 years ago

@dirk-thomas Could you tell me, what should I do with this PR?

dirk-thomas commented 4 years ago

I just got around to create a noetic-devel branch, updated some indentation in e98e35d5b1425f1dd5e9cb4f27f170f8f00d696a and will go ahead merging this,

Thanks for the improvement.

abrzozowski commented 4 years ago

Added description in the ROS wiki: http://wiki.ros.org/action/diff/rosconsole?action=diff&rev1=74&rev2=75

kakaday22 commented 2 years ago

Any possibility to have this enhancement done on Ros Melodic?