ros / rosconsole

17 stars 61 forks source link

fix console printer to also print unknown levels #34

Closed flixr closed 4 years ago

flixr commented 4 years ago

this can happen if people added their own log4cxx levels In this case, still print the message on the console in red with "UNKNO" level instead of just printing a newline.

dirk-thomas commented 4 years ago

Since you chose red as the fallback color should the message also go to stderr?

A comment about why the fallback is in place would be great, too.

flixr commented 4 years ago

good point, done...

dirk-thomas commented 4 years ago

Thanks for the patch and the quick update!