search

ros / rosconsole

17 stars 61 forks source link

Remove undesired blank spaces #52

Closed Maverobot closed 3 years ago

Maverobot commented 3 years ago

If I understand it correctly, we want to show the logging in the console like

[INFO] [1630659023.150800919]: ...

instead of 

[ INFO] [1630659023.150800919]: ...

This PR removed the undesired blank space before "INFO".

Besides, I would like to merge this change also into melodic-devel so that it can be fetched later via apt upgrade. Should I create another PR for that?

Maverobot commented 3 years ago

@dirk-thomas This is a very simple fix. Please have a look if you have time :)

dirk-thomas commented 3 years ago

@Maverobot sorry, I am not maintaining this repository anymore.

Maverobot commented 3 years ago

@dirk-thomas No problem. Sorry for bothering you. Do you happen to know who is maintaining it at the moment?

dirk-thomas commented 3 years ago

@Maverobot Unfortunately, I don't know. The information in the package manifest hasn't been updated either: https://github.com/ros/rosconsole/blob/854b3a1ec426e173383d2cf1d241c5626ec33715/package.xml#L5

Maverobot commented 3 years ago

@tfoote May I ask you to review this change here? It seems that the maintainer label in package.xml is not updated..

hidmic commented 3 years ago

Besides, I would like to merge this change also into melodic-devel so that it can be fetched later via apt upgrade.

Once this is merged, you may backport the squashed commit.

Maverobot commented 3 years ago

Once this is merged, you may backport the squashed commit.

Can you please tell me what I should do to "backport the squashed commit"?

lucasw commented 3 years ago

For future reference it appears the purpose of the space was to make the 4 character WARN and INFO log lines aligned with 5 character DEBUG, ERROR, & FATAL (& 'UNKWO') log output, making it easier to compare the timestamp that usually follows the log level with adjacent lines.

The blank space does look a little funny though, and this change makes C++ log output consistent with rospy logging over in ros_comm https://github.com/ros/ros_comm/blob/noetic-devel/tools/rosgraph/src/rosgraph/roslogging.py#L220

(I like to chop the number of characters down to 1, E for error and so on https://github.com/lucasw/rosconsole/commit/d27e51ec11ce5ce11dec2748c48cb4b33c596e41)