[Windows] Using C++11 std::chrono for ros_walltime & ros_steadytime

ros / roscpp_core

ros distribution sandbox

88 stars 116 forks source link

[Windows] Using C++11 std::chrono for ros_walltime & ros_steadytime #121

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

This pull request is motivated by https://github.com/ros/ros_comm/pull/1962.

From the issue mentioned above, I found that the roscpp has an assumption on what's the clock to use for Timer implementation. This change is trying to match the clock implementation and the goal is to reduce any potential time domain problems because of the mismatched implementation.

dirk-thomas commented 4 years ago

Thanks for the patch. Assuming you have sufficiently tested that this change works well on Windows I will go ahead and merge it.

seanyen commented 4 years ago

@dirk-thomas Thanks for the merge. It would be great to cherry-pick to kinetic-devel too for Melodic. The issue was originally reported on Melodic release on Windows. Thanks for your help again.

dirk-thomas commented 4 years ago

Cherry-picked to kinetic-devel in e408ecaed760ab9710e24fdb3f3d3ea7ec513337.