ros / roscpp_core

ros distribution sandbox
88 stars 116 forks source link

Fixed handling of infinite or >int64 doubles in Time and Duration constructors #132

Closed peci1 closed 1 year ago

peci1 commented 2 years ago

Fixed handling of infinite or >int64 doubles in Time and Duration constructors.

Also added tests for Rate(double) constructor, verified Rate(inf) works and Rate(0) does not.

Fixes #105.

peci1 commented 1 year ago

@dirk-thomas friendly ping

dirk-thomas commented 1 year ago

@peci1 Sorry, I am not involved in the project anymore for more than 2.5 years.

peci1 commented 1 year ago

@ros-pull-request-builder retest this please

peci1 commented 1 year ago

Merging without other approvals since I'm the only maintainer.

peci1 commented 1 year ago

@Mergifyio backport melodic-devel

mergify[bot] commented 1 year ago

backport melodic-devel

✅ Backports have been created

* [#140 Fixed handling of infinite or >int64 doubles in Time and Duration constructors (backport #132)](https://github.com/ros/roscpp_core/pull/140) has been created for branch `melodic-devel`