search

ros / roscpp_core

ros distribution sandbox
89 stars 116 forks source link

Create typedefs for SharedPtr, ConstSharedPtr #36

Closed scpeters closed 4 years ago

scpeters commented 9 years ago

This will match the new typedef's in ros2: https://github.com/ros2/design/pull/53

dirk-thomas commented 9 years ago

The patch looks good.

But I won't merge this now. Before this needs to be fully agreed on in the ROS 2 discussion and for the migration path it must be clear that it is useful. Currently with the include path as well as the namespace being different it is only of limited use.

scpeters commented 9 years ago

Fair enough. If you prefer, feel free to close it until the time that it is ready.

wjwwood commented 9 years ago

+1. I'd say leave it open.

scpeters commented 5 years ago

Should we still leave this open or close it?

dirk-thomas commented 4 years ago

I will close this since nobody is planning to work on this. Please feel free to comment on the closed ticket and it can be reopened if necessary.