Closed wjwwood closed 12 years ago
you're an official committer so you can commit right away, no need for a code review for such a simple fix :)
On Mon, Sep 10, 2012 at 11:18 PM, William Woodall notifications@github.comwrote:
See: http://answers.ros.org/question/43272/ros-install-problem-osx-1068/
You can merge this Pull Request by running:
git pull https://github.com/ros/roscpp_core rostime_boost_fix
Or view, comment on, or merge it at:
https://github.com/ros/roscpp_core/pull/5 Commit Summary
- rostime: Fixed a linking issue on OS X using boost 1.5+
File Changes
- M rostime/CMakeLists.txt (2)
Patch Links
- https://github.com/ros/roscpp_core/pull/5.patch
https://github.com/ros/roscpp_core/pull/5.diff
— Reply to this email directly or view it on GitHubhttps://github.com/ros/roscpp_core/pull/5.
Yup, this was a small fix, but I think it is a good habit (as you proved, someone else looked at it). In the future I will only do this with larger changes.
See: http://answers.ros.org/question/43272/ros-install-problem-osx-1068/