ros / roscpp_core

ros distribution sandbox
88 stars 116 forks source link

fix extra ‘;’ warnings when compiling with -Wpedantic #53

Closed meyerj closed 7 years ago

meyerj commented 7 years ago

Fixeds compiler warnings like:

/opt/ros/kinetic/include/ros/message_traits.h:42:30: warning: extra ‘;’ [-Wpedantic]
   ROS_DECLARE_MESSAGE(Header);                                                                                                                                                                             
                              ^
In file included from /opt/ros/kinetic/include/ros/serialization.h:38:0,
                 from /opt/ros/kinetic/include/stereo_msgs/DisparityImage.h:14,
                 from /opt/orocos/kinetic/devel_debug/include/orocos/stereo_msgs/boost/DisparityImage.h:9,
                 from /opt/orocos/kinetic/build_debug/rtt_stereo_msgs/stereo_msgs_typekit/ros_stereo_msgs_typekit.cpp:1:
/opt/ros/kinetic/include/ros/builtin_message_traits.h:43:37: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(uint8_t);                                                                                                                                                                      
                                     ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:44:36: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(int8_t);                                                                                                                                                                       
                                    ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:45:38: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(uint16_t);                                                                                                                                                                     
                                      ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:46:37: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(int16_t);                                                                                                                                                                      
                                     ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:47:38: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(uint32_t);                                                                                                                                                                     
                                      ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:48:37: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(int32_t);                                                                                                                                                                      
                                     ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:49:38: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(uint64_t);                                                                                                                                                                     
                                      ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:50:37: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(int64_t);                                                                                                                                                                      
                                     ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:51:35: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(float);                                                                                                                                                                        
                                   ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:52:36: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(double);                                                                                                                                                                       
                                    ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:53:34: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(Time);                                                                                                                                                                         
                                  ^
/opt/ros/kinetic/include/ros/builtin_message_traits.h:54:38: warning: extra ‘;’ [-Wpedantic]
 ROSLIB_CREATE_SIMPLE_TRAITS(Duration);                                                                                                                                                                     
                                      ^
In file included from /opt/ros/kinetic/include/stereo_msgs/DisparityImage.h:14:0,
                 from /opt/orocos/kinetic/devel_debug/include/orocos/stereo_msgs/boost/DisparityImage.h:9,
                 from /opt/orocos/kinetic/build_debug/rtt_stereo_msgs/stereo_msgs_typekit/ros_stereo_msgs_typekit.cpp:1:
/opt/ros/kinetic/include/ros/serialization.h:225:42: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(uint8_t);                                                                                                                                                                 
                                          ^
/opt/ros/kinetic/include/ros/serialization.h:226:41: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(int8_t);                                                                                                                                                                  
                                         ^
/opt/ros/kinetic/include/ros/serialization.h:227:43: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(uint16_t);                                                                                                                                                                
                                           ^
/opt/ros/kinetic/include/ros/serialization.h:228:42: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(int16_t);                                                                                                                                                                 
                                          ^
/opt/ros/kinetic/include/ros/serialization.h:229:43: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(uint32_t);                                                                                                                                                                
                                           ^
/opt/ros/kinetic/include/ros/serialization.h:230:42: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(int32_t);                                                                                                                                                                 
                                          ^
/opt/ros/kinetic/include/ros/serialization.h:231:43: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(uint64_t);                                                                                                                                                                
                                           ^
/opt/ros/kinetic/include/ros/serialization.h:232:42: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(int64_t);                                                                                                                                                                 
                                          ^
/opt/ros/kinetic/include/ros/serialization.h:233:40: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(float);                                                                                                                                                                   
                                        ^
/opt/ros/kinetic/include/ros/serialization.h:234:41: warning: extra ‘;’ [-Wpedantic]
     ROS_CREATE_SIMPLE_SERIALIZER(double); 
                                         ^

Output is with ROS kinetic and rospp_core 0.6.1 installed from deb, but I created the PR for the indigo-devel. It cleanly applies to kinetic-devel, too.

See also related PR https://github.com/ros/gencpp/pull/26 for the generated headers.

dirk-thomas commented 7 years ago

Thank you for the contribution.