search

ros / roscpp_core

ros distribution sandbox
88 stars 116 forks source link

Added exceptions to prevent overflow bugs. #60

Closed aliscafo closed 7 years ago

dirk-thomas commented 7 years ago

@aliscafo Can you please address the comment in order for this PR to be considered for merging. Thank you.

dirk-thomas commented 7 years ago

The patch also overlaps with #58. Please take a look if that PR covers all the case which you are trying to address in this PR.

aliscafo commented 7 years ago

Hi Thomas,

Thank you for your answer about the pull-request. It was my university project, so I'm not sure if my work should be considered for merging.

Regards, Alina

19 июл. 2017 г. 1:26 пользователь "Dirk Thomas" notifications@github.com написал:

The patch also overlaps with #58 https://github.com/ros/roscpp_core/pull/58. Please take a look if that PR covers all the case which you are trying to address in this PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ros/roscpp_core/pull/60#issuecomment-316216325, or mute the thread https://github.com/notifications/unsubscribe-auth/AVBtrF2JPQD5dSgYUm2xVpawJDGyy1yDks5sPTESgaJpZM4N2M01 .

dirk-thomas commented 7 years ago

I created #61 to cover the changes from #58. Compared to those this PR still adds a couple of sanity checks. They still seem to be valuable to have. So I separated them in #62.

dirk-thomas commented 7 years ago

I will close this in favor of #62 (and #61). It would be great if you could still comment here or on #62 about the modified patch. Thanks!