search

ros / roscpp_core

ros distribution sandbox
89 stars 116 forks source link

Make message_events build for ros2 (on windows 10) #72

Closed bfjelds closed 6 years ago

bfjelds commented 6 years ago

Should go to a ROS2 branch.

Working towards enabling laser_filters in ROS2. This provides message_events for message_filters.

dirk-thomas commented 6 years ago

Thank you for starting this PR.

I am not really sure I understand the scope of the patch though. The packages in this repo are very specific to the generated C++ code of ROS 1 messages. Even with the proposed changes those wouldn't be used in ROS 2 messages anywhere. So I currently don't see how this would be useful.

Maybe you can provide a more detailed context, describe the goal as well as provide steps how to reproduce what you are trying to achieve with this (and related) PRs.

bfjelds commented 6 years ago

My end goal was really to get laser_filters working, so I generally just chipped away at what needed porting without too much thought towards refactoring or bigger picture. This was created because rostime, message_event and the traits were needed to enable laser_filters.

Note there are a couple other PRs included in the work to get laser_filters going:

https://github.com/ros/filters/pull/19 https://github.com/ros2/geometry2/pull/53/

dirk-thomas commented 6 years ago

Please check if the upcoming changes in ros2/message_filters#2 are covering all the cases of this patch.

dirk-thomas commented 6 years ago

Closing in favor of ros2/message_filters#5.