search

ros / roscpp_core

ros distribution sandbox
89 stars 116 forks source link

the destructor of DurationBase is not virtual #86

Closed csukuangfj closed 5 years ago

csukuangfj commented 6 years ago

See the code

https://github.com/ros/roscpp_core/blob/d2bb8cbcfd4944e48d16cdb20edfab5d225db265/rostime/include/ros/duration.h#L79

https://github.com/ros/roscpp_core/blob/d2bb8cbcfd4944e48d16cdb20edfab5d225db265/rostime/include/ros/duration.h#L108

dirk-thomas commented 5 years ago

The proposal has changed to remove the destructor in #104.