search

ros / rosdistro

This repo maintains a lists of repositories for each ROS distribution
Other
905 stars 2.54k forks source link

Add `luma.core` and `luma.oled` pip dependencies to python.yaml #42073

Closed SPGC closed 5 days ago

SPGC commented 1 month ago

Please add the following dependency to the rosdep database.

Package name:

luma.core, luma.oled

Package Upstream Source:

luma.core - https://github.com/rm-hull/luma.core luma.oled - https://github.com/rm-hull/luma.oled

Reason to add:

  1. luma.core - component library providing a Pillow-compatible drawing canvas for Python 3, and other functionality to support drawing primitives and text-rendering capabilities for small displays on the Raspberry Pi and other single board computers
  2. luma.oled - Python 3 library interfacing OLED matrix displays with the SSD1306, SSD1309, SSD1322, SSD1325, SSD1327, SSD1331, SSD1351, SH1106, SH1107 or WS0010 driver using I2C/SPI/Parallel on the Raspberry Pi and other linux-based single-board computers

Both libraries are useful for rendering on displays on robots

Links to Distribution Packages

marcoag commented 1 month ago

A quick search shows me that this packages exist in Ubuntu noble :

https://packages.ubuntu.com/noble/python3-luma.core https://packages.ubuntu.com/noble/python3-luma.oled

and in consequence at least in Debian bookwrom. We usually try to avoid adding pip packages where binaries are available at the system leve, i.e.: https://github.com/ros/rosdistro/pull/41870#pullrequestreview-2148978970.

If you're looking to add it to a specific OS that don't have the system package please narrow down the scope of the rosdistro entry.

mjcarroll commented 1 month ago

@SPGC friendly ping

SPGC commented 1 month ago

A quick search shows me that this packages exist in Ubuntu noble :

https://packages.ubuntu.com/noble/python3-luma.core https://packages.ubuntu.com/noble/python3-luma.oled

and in consequence at least in Debian bookwrom. We usually try to avoid adding pip packages where binaries are available at the system leve, i.e.: #41870 (review).

If you're looking to add it to a specific OS that don't have the system package please narrow down the scope of the rosdistro entry.

Changed to binary package for Ubuntu

github-actions[bot] commented 1 week ago

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

clalancette commented 5 days ago

This is failing CI, and there has been no response to the outstanding comments from 3 weeks ago. I'm going to go ahead and close this, but if you'd still like to get it merged please feel free to reopen.