ros / rosdistro

This repo maintains a lists of repositories for each ROS distribution
Other
905 stars 2.54k forks source link

ros2_socketcan: 1.3.0-1 in 'humble/distribution.yaml' [bloom] #42117

Closed xmfcx closed 1 month ago

xmfcx commented 1 month ago

Increasing version of package(s) in repository ros2_socketcan to 1.3.0-1:

ros2_socketcan

* Jazzy release
* fix: add missing header (#42 <https://github.com/autowarefoundation/ros2_socketcan/issues/42>)
* Allow remapping of the canbus topics (#39 <https://github.com/autowarefoundation/ros2_socketcan/issues/39>)
* Contributors: Joshua Whitley, Tim Clephas

ros2_socketcan_msgs

* Jazzy release
xmfcx commented 1 month ago

Related PRs:

PRs for other distributions for this same tag:

christophebedard commented 1 month ago

Looks good now!

xmfcx commented 1 month ago

@christophebedard Thanks for all the help, this was one of the most complicated things I did in my life (first time releasing a package with bloom).

It would have taken me way too much time to figure out the issue with humble release_repo_url being wrong. I don't even know why humble and older distros point to the autowarefoundation fork of the repo. Or why the fork exists at all (maybe https://github.com/ros2-gbp/ros2-gbp-github-org system of handling user permissions didn't exist back then?)

I hope everything works out in the long run, I think I did all that I could, hopefully right :sweat_smile:

christophebedard commented 1 month ago

Yeah, at some point a lot of release repos were moved to https://github.com/ros2-gbp/. I assume some of the URLs were just not updated.

xmfcx commented 1 month ago

Should I remove or archive the autowarefoundation fork and update the release_repo_url of all the other distros too?

christophebedard commented 1 month ago

I think you can definitely archive it (so that it is read-only). Then you can just let the end-of-life distros (i.e., Galactic and older) keep pointing to it; no need to change those.