search

ros / rospack

A command-line tool for retrieving information about ROS packages available on the filesystem
15 stars 65 forks source link

Add missing run_depend on roslib #36

Closed cottsay closed 10 years ago

cottsay commented 10 years ago

rospack doesn't generate any error if roslib isn't installed, but it is unable to find any packages without it

I would appreciate a backport to hydro and groovy for this one

cottsay commented 10 years ago

For whatever reason I thought that this was isolated, but it looks like it is failing builds on the farm, too. See:

Clearly rospack and mk get installed, but when rospack is used to find mk, it fails to do so.

I hit the same problem on Fedora and ensuring that roslib was installed fixed it entirely.

dirk-thomas commented 10 years ago

Actually roslib depends on rospack (https://github.com/ros/ros/blob/indigo-devel/core/roslib/package.xml) which mean this PR would generate a circular dependency and therefore not be merged anyway. I will therefore close this PR.

I think the actual problem here is that you are trying to do some highly discouraged stuff in your package, e.g. downloading external code in the build process (which are not unit test data). Your process requires rospack to be able to resolve other packages at build time which is not supported.

In order to make your packages build as they are you must build_depend on roslib. But you might want to consider refactoring your whole CMake process for these packages.

cottsay commented 10 years ago

Thanks, @dirk-thomas, I'll make sure the package's maintainers are aware of this.

dirk-thomas commented 10 years ago

Oh, I assumed these are your packages :wink: It would be great if you can inform the maintainers. Thanks.

cottsay commented 10 years ago

I'm just wading through the hydro packages and fixing compile problems on Fedora. Turns out that this one wasn't even compiling on Ubuntu... This will fix it though. Thanks again.