ros / sdformat_urdf

A urdf_parser_plugin using libsdformat to parse SDFormat XML into URDF structures
33 stars 8 forks source link

Fix Humble / Rolling build #9

Closed chapulina closed 2 years ago

chapulina commented 2 years ago

This PR has the bare minimum to get GitHub actions running and passing for the ros2 branch.

sloretz commented 2 years ago

Looks like the sdformat12 rosdep key needs an entry on Jammy

https://github.com/ros/rosdistro/blob/8db58d767c12ffca910ccefd2068765cf11bcb63/rosdep/base.yaml#L7076-L7080

13:05:37 Traceback (most recent call last):
13:05:37   File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 306, in <module>
13:05:37     main()
13:05:37   File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 138, in main
13:05:37     debian_pkg_names_building = resolve_names(build_depends, **context)
13:05:37   File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 289, in resolve_names
13:05:37     resolved_names = resolve_for_os(
13:05:37   File "/usr/lib/python3/dist-packages/rosdep2/catkin_support.py", line 91, in resolve_for_os
13:05:37     inst_key, rule = d.get_rule_for_platform(os_name, os_version, os_installers, default_os_installer)
13:05:37   File "/usr/lib/python3/dist-packages/rosdep2/lookup.py", line 132, in get_rule_for_platform
13:05:37     raise ResolutionError(rosdep_key, self.data, os_name, os_version, 'No definition of [%s] for OS version [%s]' % (rosdep_key, os_version))
13:05:37 rosdep2.lookup.ResolutionError: No definition of [sdformat12] for OS version [jammy]
13:05:37    rosdep key : sdformat12
13:05:37    OS name    : ubuntu
13:05:37    OS version : jammy
13:05:37    Data:
13:05:37 debian:
13:05:37          buster:
13:05:37          - libsdformat12-dev
13:05:37        ubuntu:
13:05:37          focal:
13:05:37          - libsdformat12-dev
chapulina commented 2 years ago

Looks like the sdformat12 rosdep key needs an entry on Jammy

Ouch, my bad, here we go:

chapulina commented 2 years ago

Rebased on top of #10

chapulina commented 2 years ago

Ouch 😕 @sloretz I had updated this PR to have only the source code updates

sloretz commented 2 years ago

Ah ooops I didn't mean to close this, and I can't seem to reopen it. I deleted the branch sloretz__ci_focal_jammy after merging #10. That seems to put this PR in a bad state since it was targeting that branch. I can't even re-target it to the ros2 branch :(

chapulina commented 2 years ago

haha no worries, I can open a new PR

chapulina commented 2 years ago