ros / urdf

Repository for URDF parsing code
63 stars 41 forks source link

update include statements to use new pluginlib and class_loader headers #17

Closed mikaelarguedas closed 6 years ago

mikaelarguedas commented 6 years ago

Disclaimer: This in an automated PR, if it is not relevant on this branch, apologies for the inconveniance, feel free close it.


pluginlib and class_loader headers have been refactored and renamed. The previous headers .h have been deprecated in favor of their .hpp equivalent. The new headers are available on all active ROS distributions and the deprecated ones will be removed in a future version of ROS (likely ROS-N).

This PR migrates the include statements to use the non-deprecated ones and should compile for any active ROS distribution starting with Indigo The migration was done by running the scripts pluginlib_headers_migration.py and class_loader_headers_update.py on this repository.

sloretz commented 6 years ago

@mikaelarguedas Is the new header now available in kinetic? #16 fixed this on melodic, but I didn't do the same in kinetic because class_loader.hpp didn't seem to exist.

mikaelarguedas commented 6 years ago

Yes these headers have been released in indigo, kinetic, lunar and melodic. Some have been available on the main repository only since the last sync (a few days ago) so that may be the reason.

Just double-checked locally just in case :) :

$ dpkg -c ros-kinetic-class-loader_0.3.9-0xenial-20180316-113344-0800_amd64.deb | grep hpp
-rw-r--r-- root/root      2645 2018-03-16 11:20 ./opt/ros/kinetic/include/class_loader/console_bridge_compatibility.hpp
-rw-r--r-- root/root     13504 2018-03-16 11:20 ./opt/ros/kinetic/include/class_loader/class_loader.hpp
-rw-r--r-- root/root      6573 2018-03-16 11:20 ./opt/ros/kinetic/include/class_loader/meta_object.hpp
-rw-r--r-- root/root      3636 2018-03-16 11:20 ./opt/ros/kinetic/include/class_loader/exceptions.hpp
-rw-r--r-- root/root     13904 2018-03-16 11:20 ./opt/ros/kinetic/include/class_loader/multi_library_class_loader.hpp
-rw-r--r-- root/root      3626 2018-03-16 11:20 ./opt/ros/kinetic/include/class_loader/register_macro.hpp
-rw-r--r-- root/root     16067 2018-03-16 11:20 ./opt/ros/kinetic/include/class_loader/class_loader_core.hpp
$ dpkg -c ros-kinetic-pluginlib_1.11.3-0xenial-20180316-120623-0800_amd64.deb | grep hpp
-rw-r--r-- root/root     30433 2018-03-16 11:40 ./opt/ros/kinetic/include/pluginlib/class_loader_imp.hpp
-rw-r--r-- root/root     13979 2018-03-16 11:40 ./opt/ros/kinetic/include/pluginlib/class_loader.hpp
-rw-r--r-- root/root      3739 2018-03-16 11:40 ./opt/ros/kinetic/include/pluginlib/exceptions.hpp
-rw-r--r-- root/root      3362 2018-03-16 11:40 ./opt/ros/kinetic/include/pluginlib/class_desc.hpp
-rw-r--r-- root/root      4403 2018-03-16 11:40 ./opt/ros/kinetic/include/pluginlib/class_list_macros.hpp
-rw-r--r-- root/root      6145 2018-03-16 11:40 ./opt/ros/kinetic/include/pluginlib/class_loader_base.hpp
sloretz commented 6 years ago

Thanks @mikaelarguedas !