update deprecated macro for MSVC

ros / urdf

Repository for URDF parsing code

63 stars 41 forks source link

update deprecated macro for MSVC #27

Closed kejxu closed 5 years ago

kejxu commented 5 years ago

update deprecated macro to __declspec(deprecated(msg)) for MSVC

kejxu commented 5 years ago

thanks for approving the change @sloretz! is there anything else we would need before merging?

seanyen commented 5 years ago

@sloretz Ping! I saw this got approved but it is still open (#27, #28 and #29). Let @kejxu or me know anything from us to make them merged back to the upstream. Thanks!

clalancette commented 5 years ago

Looks good, merging.