search

ros / urdf

Repository for URDF parsing code
63 stars 41 forks source link

update compiler flags #29

Closed kejxu closed 4 years ago

kejxu commented 5 years ago

update how c++11 compiler flag is added:

the other way to do this is to use target_compile_features(mylib PUBLIC cxx_std_11) from cmake, but this would mean to add this line for every target. would this be preferred instead of adding a global c++11 flag?

kejxu commented 5 years ago

just pinging on the thread @clalancette =) Would we be able to get a review for this simple change?

this change is similar to https://github.com/ros/kdl_parser/pull/24 and https://github.com/ros/robot_state_publisher/pull/104, would you want set (CMAKE_CXX_STANDARD 14) for all these 3 repositories?

seanyen commented 5 years ago

Thank @kejxu for driving it! And just want to add more context that the -Wno-deprecated-declarations flag will cause build break for MSVC on the run_tests build, and that's why we made it conditionally.


cl   /TP -DNOMINMAX -DNO_STRICT -DQ_NOWINSTRICT -DROSCONSOLE_BACKEND_LOG4CXX -DROS_BUILD_SHARED_LIBS=1 -DROS_PACKAGE_NAME=\"urdf\" -DWIN32_LEAN_AND_MEAN -D_USE_MATH_DEFINES -IC:\catkin_ws\devel_isolated\urdf\include -IC:\catkin_ws\src\urdf\urdf\include -IC:\opt\rosdeps\x64\include\boost-1_66 -IC:\opt\ros\melodic\x64\include -IC:\opt\ros\melodic\x64\share\xmlrpcpp\cmake\..\..\..\include\xmlrpcpp -IC:\opt\rosdeps\x64\include /DWIN32 /D_WINDOWS /W3 /GR /EHsc /MD /Zi /O2 /Ob1 /DNDEBUG   /D _VARIADIC_MAX=10 /Zc:__cplusplus -std=c++11 -Wno-deprecated-declarations /FoCMakeFiles\test_model_parser_initxml.dir\test\test_model_parser_initxml.cpp.obj /FdCMakeFiles\test_model_parser_initxml.dir\ /FS -c C:\catkin_ws\src\urdf\urdf\test\test_model_parser_initxml.cpp
cl : Command line error D8021 : invalid numeric argument '/Wno-deprecated-declarations'
seanyen commented 5 years ago

@clalancette Just a friendly reminder for this open pull request. Hope you can take a look of this change and help us to swap to build ROS on Windows from the upstream urdf repository. And really appreciated your help!