search

ros / urdf_parser_py

Standalone URDF parser for Python.
83 stars 48 forks source link

Python 3 support #38

Closed timonegk closed 5 years ago

timonegk commented 5 years ago

Some small changes to make urdf_parser_py able to run in python3.

timonegk commented 5 years ago

Even though .decode() would work, I think that providing the encoding='unicode' parameter is the better solution because it is easier to understand. In the background, both are the same (see the lxml source). I will edit my commit in a second.

eacousineau commented 5 years ago

Should we perhaps revive Travis CI for Python3-only testing, if we want to vet PRs to ensure that they don't break anything? (at least until the buildfarm supports that configuration?)

nzlz commented 5 years ago

Hey guys, could you accept this PR? I faced the same issue and had to create a solution like the one posted here. Using the official repo is always more convenient.

I can create the PR to a new branch if this is the issue.