search

ros / urdf_parser_py

Standalone URDF parser for Python.
86 stars 48 forks source link

Add in support for the version tag. #52

Closed clalancette closed 4 years ago

clalancette commented 4 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Just like in urdfdom, add support for the version tag in the URDF XML. Note that I ended up adding the version tag by hand to all of the round-trip tests so that they pass; there are other tests that test the lack of a version tag, so I think this is fine. @sloretz @scpeters FYI.

scpeters commented 4 years ago

this also looks good; just one more minor comment

scpeters commented 4 years ago

The concerns about parsing floats in https://github.com/ros/urdfdom/pull/133#issuecomment-557274975 are relevant here too

scpeters commented 4 years ago

I think we need to update the version parsing here too

clalancette commented 4 years ago

I think we need to update the version parsing here too

Yeah, definitely, I just ran out of time yesterday. I'll get to this early next week.

clalancette commented 4 years ago

Yeah, definitely, I just ran out of time yesterday. I'll get to this early next week.

OK, late this week, but I did finally get it done. I switched this to a string now, and updated the tests to match the C++ ones in 9f78b7f. This is ready for another review.

clalancette commented 4 years ago

Thanks for the reviews! I've made fixes corresponding to the reviews in e832a00. @sloretz @scpeters ready for another round.

clalancette commented 4 years ago

Thanks! Merging.