search

ros / urdf_parser_py

Standalone URDF parser for Python.
86 stars 48 forks source link

ROS 2 Port (reopened) #53

Closed henningkayser closed 4 years ago

henningkayser commented 4 years ago

This is a cleaned up version of #41 (fixed, squashed and rebased onto melodic-devel).

@clalancette Do you still want a version bump to 1.0.0 or would it suffice to add a ros2 to the tag?

clalancette commented 4 years ago

Thanks for picking this up! I'd like to separate the work on the melodic-devel branch from the actual port, so I've updated the ros2 branch to have all of the commits from melodic-devel. It seems like GitHub isn't actually picking that up for some reason, so I'm going to close and reopen this PR to try and do that. I'll also do a regular review.

clalancette commented 4 years ago

This looks generally good.

About the version number, we should definitely bump to 1.0.0. We can't just add a tag to the version since the backend tooling can't handle it, so let's bump that up to 1.0.0, rebase this, and then I think we can merge this in.

clalancette commented 4 years ago

Looks good to me! I'm going to merge it. I'd like to #52 onto melodic and this branch, so I'll hold off doing a release until we get that done.

henningkayser commented 4 years ago

Looks good to me! I'm going to merge it. I'd like to #52 onto melodic and this branch, so I'll hold off doing a release until we get that done.

Thanks!

clalancette commented 4 years ago

At long last, I've now released this for ROS 2 Dashing and Eloquent. Thanks for the patience here.