search

ros / urdf_parser_py

Standalone URDF parser for Python.
86 stars 48 forks source link

Make sure to add the version when creating a new URDF. #62

Closed clalancette closed 4 years ago

clalancette commented 4 years ago

It turns out that when I added the version stuff, I completely forgot about creating a new URDF. This PR fixes it so that we can successfully round-trip through the URDF parser, and adds tests to ensure the same.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Note that once this is reviewed, approved, and merged, I'll do a similar fix for the ROS 1 code. This should fix #59

clalancette commented 4 years ago

@sloretz Friendly ping on this one; mind reviewing?

clalancette commented 4 years ago

Thanks, appreciate the review. Merging.

traversaro commented 3 years ago

Note that once this is reviewed, approved, and merged, I'll do a similar fix for the ROS 1 code. This should fix #59

Hi @clalancette, let us know if there is anything we can do to help to get the fix shipped also to the melodic-devel branch of the repo, that is the default branch, thanks!

clalancette commented 3 years ago

Hi @clalancette, let us know if there is anything we can do to help to get the fix shipped also to the melodic-devel branch of the repo, that is the default branch, thanks!

It totally fell off of my radar, thanks for the ping. See #66 for the ROS 1 fix.