Closed clalancette closed 4 years ago
@sloretz Friendly ping on this one; mind reviewing?
Thanks, appreciate the review. Merging.
Note that once this is reviewed, approved, and merged, I'll do a similar fix for the ROS 1 code. This should fix #59
Hi @clalancette, let us know if there is anything we can do to help to get the fix shipped also to the melodic-devel
branch of the repo, that is the default branch, thanks!
It turns out that when I added the version stuff, I completely forgot about creating a new URDF. This PR fixes it so that we can successfully round-trip through the URDF parser, and adds tests to ensure the same.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that once this is reviewed, approved, and merged, I'll do a similar fix for the ROS 1 code. This should fix #59