search

ros / urdf_parser_py

Standalone URDF parser for Python.
83 stars 48 forks source link

Use a Python entry point for 'display_urdf' #64

Closed cottsay closed 3 years ago

cottsay commented 4 years ago

On many platforms, the unversioned python executable is not Python 2. A better solution here would be to change this package to use an entry point, as shebang python scripts don't work correctly on Windows.

This same change applies to Noetic, but there isn't a Noetic-specific branch to make the change against.

cottsay commented 4 years ago

remove the shebang, make the script not executable, and add a console_scripts entrypoint in the setup.py

Done. I split it into three commits. The first resolves a ROS 2 bug, the second does the move, and the third fixes up the script as an entry point. We should rebase-merge this to preserve the change history of display_urdf.

I don't think any changes are needed in ROS 1

You're right, I forgot about that. Good call - no changes necessary for ROS 1.

clalancette commented 3 years ago

@cottsay Friendly ping here; I think this is close to getting done, with just a couple more nits to fix from @sloretz .

cottsay commented 3 years ago

Okay, I dropped the argv stuff. Again, please rebase-merge this PR when you're happy with it - I updated the commits to include a reference to this PR so they look good when rebase-merged.

clalancette commented 3 years ago

I'm going to go ahead and merge this, thanks for the patch @cottsay