Link Visual and Collision are not exported to XML

ros / urdf_parser_py

Standalone URDF parser for Python.

86 stars 48 forks source link

Link Visual and Collision are not exported to XML #80

Open AdrianZw opened 1 year ago

AdrianZw commented 1 year ago

I realized, that Visual and Collision are not exported to XML, if they are set via the Constructor. There is also an open issue for it #42. In addition, I realized that this issue was already fixed on the melodic-branch, see pull request #47.

Consequently, I cherry-pick the changes introduced with #47. In addition, I had to remove one test, since the Visual class does not have an attribute name anymore.

Closes: #42 Relates: #47

AdrianZw commented 1 year ago

Can you please retarget these changes to the ros2 branch? That's where most of the development for ROS 2 happens. Once that is done, I'll do a more detailed review. Thanks!

I did not find a way to change the branch from which the changes are pulled from. (Unless opening a new PR) Thus, I repurposed the foxy-devel branch. Might not be the cleanest way, to do it ...