ros / urdf_tutorial

233 stars 257 forks source link

Ros control tutorials #14

Closed paulbovbel closed 9 years ago

paulbovbel commented 9 years ago

Address #12

Primary change to early tutorials is to clean-up formatting, and rotate robot to be x-forward (it was previously y-forward).

Will implement the following updates to wiki:

paulbovbel commented 9 years ago

To see a demo, in a ROS workspace:

git clone git@github.com:clearpathrobotics/urdf_tutorial.git -b ros-control-tutorials rosdep install --from-paths . --ignore-src -y

roslaunch urdf_tutorial control.launch rosrun rqt_robot_steering rqt_robot_steering

set topic to /r2d2_diff_drive_controller/cmd_vel

DLu commented 9 years ago

Overall, looks good, and thanks for doing this.

However, its missing dependencies on controller_manager and gazebo_ros, as well as gazebo_worlds which seems to be deprecated. At the moment, this is what's stopping me from running the demo.

paulbovbel commented 9 years ago

@DLu, thanks for the attention, I've added a roslaunch check and resolved all dependency issues, lemme know if there's any other trouble.

DLu commented 9 years ago

This is the first part of the tutorial that really splits along distributions, since position_controllers/JointGroupPositionController doesn't exist prior to indigo. I've created new tags to reflect this.

However, since hydro won't get any new versions, I think we don't have change the PR.

DLu commented 9 years ago

I ran the tutorial and everything worked out great. Nice work. Turns out I made a not very stable r2d2 model; I kept knocking him over.

In addition to the two minor things above, one future request would be to add the textures, but that's not needed for this control work.

paulbovbel commented 9 years ago

Done. Intertial info should definitely be looked over at some point (open ticket?), but the model so far is fine for demo/tutorial purposes.

DLu commented 9 years ago

Merged. I started #15 to track the new wiki changes.

DLu commented 9 years ago

Thanks again for this valuable contribution.