search

ros / urdf_tutorial

233 stars 257 forks source link

Potetial Issue with launch file #68

Closed zacharyyamaoka closed 10 months ago

zacharyyamaoka commented 11 months ago

in https://github.com/ros/urdf_tutorial/blob/ros2/launch/display.launch.py

line 23 -> ld.add_action(DeclareLaunchArgument(name='model', default_value=str(default_model_path), description='Path to robot urdf file relative to urdf_tutorial package'))

I belive there shouldn't be the str() there. It prevents the default value from actually working!

clalancette commented 11 months ago

I belive there shouldn't be the str() there. It prevents the default value from actually working!

Yep, you are absolutely correct. Removing that str makes it work. I'll submit a PR to fix it right now. Thanks!

DLu commented 10 months ago

Good catch, thanks!