search

ros / urdf_tutorial

226 stars 253 forks source link

Add forgotten package path #72

Closed ukicomputers closed 2 months ago

ukicomputers commented 2 months ago

As in ROS 2 docs contain example here: https://docs.ros.org/en/jazzy/Tutorials/Intermediate/Launch/Using-Substitutions.html#parent-launch-file, it's shown off that every called substitution needs to have FindPackageShare(). Here, that is not the case. Even if code is working, it is probably required to add the FindPackageShare().

Sorry if I am wrong, I am newcomer to ROS 2.

ukicomputers commented 2 months ago

Sorry, I just saw: https://github.com/ros/urdf_launch/blob/main/launch/description.launch.py#L20 Again, sorry. Closing this pull request as it's not needed.