search

ros / urdfdom

URDF parser
http://ros.org/wiki/urdf
Other
96 stars 132 forks source link

Add in some tests for the strToDouble conversion. #109

Closed clalancette closed 6 years ago

clalancette commented 6 years ago

Note that this only tests that some simple cases do the correct thing. We can't reliably check the locale fixing code because we can't depend on any particular locales being installed on test machines.

This depends on https://github.com/ros/urdfdom_headers/pull/42, so should not be merged until that one is.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

scpeters commented 6 years ago

In https://github.com/ros/urdfdom/commit/0e14f00aa390e708687eefb6dda0f70685666975 I made a test commit that will use the stream-vector branch of urdfdom_headers in travis, just to confirm with CI

scpeters commented 6 years ago

CI looks good on my test branch

clalancette commented 6 years ago

I'm actually going to close this out and re-open to re-trigger Travis now that ros/urdfdom_headers#42 has been merged.

clalancette commented 6 years ago

The "push" one is failing, but that's because it ran before the urdfdom_headers PR was in. Since the other Travis CI looks good, I'm going to merge this. Thanks!