ros / urdfdom

URDF parser
http://ros.org/wiki/urdf
Other
96 stars 132 forks source link

Use tinyxml2 instead of tinyxml #185

Closed felixf4xu closed 12 months ago

felixf4xu commented 1 year ago

Hi,

I'm trying to compile ros2 from source on Windows 11 and urdfdom is the only repo that I need to change the code manually.

The reason is the dependency of "tinyxml" and I really hope "tinyxml2" should be used.

Reason:

When I check the code and issues, I found that the current branch of [scpeters/tinyxml2] (https://github.com/ros/urdfdom/tree/scpeters/tinyxml2) did exactly what I wanted and it also provides a cmake option to be back compatible (which I don't think is necessary, though)

So, please merge the branch and say goodbye to tinyxml.

uilianries commented 1 year ago

The TinyXML project is abandoned, and the latest release is from 2011 (https://sourceforge.net/projects/tinyxml/files/tinyxml/). Please, consider updating to TinyXML-2, it's a well maintained project and with frequent releases.

chging commented 1 year ago

i have the same question, why not use tinyxml2

scpeters commented 12 months ago

this will be fixed by https://github.com/ros/urdfdom/pull/186