ros / urdfdom

URDF parser
http://ros.org/wiki/urdf
Other
97 stars 131 forks source link

Fixed joints parse limits but not axis #193

Open AdamPettinger opened 8 months ago

AdamPettinger commented 8 months ago

I have the socket of a ball joint modeled as a fixed link (as a parent to a floating joint for the ball joint). The joint that models where the socket is located is a fixed type joint. I thought it would be nice to pass all relevant location/limit/axis parameters of the socket into my URDF. However, I noticed that the axis tag is not read for fixed (and floating) joints, see below https://github.com/ros/urdfdom/blob/29426ec119e9c3a9df9fc705d08c262a97b7f285/urdf_parser/src/joint.cpp#L424-L425

This is consistent with the standard "Fixed and floating joints do not use the axis field." from here. Why not parse the axis anyway? And relatedly, why parse the axis limits (what is an effort limit for a fixed joint?) but NOT the axis?

Making the change to parse the axis should be easy, and I would be wiling to do it. Am I missing a compelling reason to not parse axes on fixed and floating joints?