search

ros / urdfdom

URDF parser
http://ros.org/wiki/urdf
Other
97 stars 131 forks source link

support export URDF #199

Open briansoe66 opened 6 months ago

briansoe66 commented 6 months ago

I would like to use the export functions. However, they are deprecated, so that the tinyxml2 dependency is private, as described in: PR #190

I propose changing the API, so that export is available does not use tinyxml2. If this is acceptable, I can create a PR.

URDFDOM_DLLAPI std::string  exportURDF(ModelInterfaceSharedPtr &model);

URDFDOM_DLLAPI std::string  exportURDF(const ModelInterface &model);
clalancette commented 6 months ago

In general, I am OK with that, but you are going to have to call them something different since we want to leave the existing deprecated ones in place for now . That's because in C++ you can't have an overload that differs only in the return type.