search

ros / urdfdom

URDF parser
http://ros.org/wiki/urdf
Other
96 stars 132 forks source link

[test] add extended tests for pose::get/setRPY #67

Closed traversaro closed 8 years ago

traversaro commented 9 years ago

One testcase added to highlight https://github.com/ros/urdfdom_headers/issues/18

Furthermore, a vast range of rpy test cases (obtained as the permutation of given list of angles) was added to make sure that they are all handled properly.

By the way, why this test was added in this repository @vrabaud ? It is only testing code that is contained in the urdfdom_headers repo.

scpeters commented 8 years ago

Nice test! +1 after the urdfdom_headers PR is merged

scpeters commented 8 years ago

Since https://github.com/ros/urdfdom_headers/issues/19 has been merged, this can be merged as well.

jacquelinekay commented 8 years ago

@traversaro thanks for the fix. The test was probably added to this repo instead of urdfdom_headers because urdfdom_headers has no existing test infrastructure, because most of the implementation is in this repo.