Implemented RCL global argument parsing.

ros2-dotnet / ros2_dotnet

.NET bindings for ROS2

Apache License 2.0

136 stars 54 forks source link

Implemented RCL global argument parsing. #122

Closed Chootin closed 8 months ago

Chootin commented 9 months ago

Also implemented methods for getting the name and namespace of nodes.

Chootin commented 9 months ago

I have, since this, done a lot more work on my fork:

Made the clock available in .NET including setting the type
Implemented parameter handling (this must be done for each language specific library as per https://github.com/ros2/rcl/blob/1260197bb53353ce91a129a47ba0271eea2033a2/rcl/include/rcl/node.h#L88)
Implemented use_sim_time into Node.cs

All of this is currently merged into my dev branch at: https://github.com/Chootin/ros2_dotnet/tree/dev

hoffmann-stefan commented 9 months ago

@Chootin Thanks for your PR 👍

Currently I'm on vacation and getting things done at home, will look take a look at this when I'm back in office.

Chootin commented 9 months ago

@Chootin Thanks for your PR 👍

Currently I'm on vacation and getting things done at home, will look take a look at this when I'm back in office.

No worries mate, enjoy the vacation!

Chootin commented 9 months ago

I have implemented the requested changes, along with Node.FullyQualifiedName using some generics to cut down on duplicated code and provide an easy way to implement similar methods should they be required in the future.

Chootin commented 8 months ago

Comment by @hoffmann-stefan addressed 👍

hoffmann-stefan commented 8 months ago

Thank you for your contribution 👍