search

ros2-dotnet / ros2_dotnet

.NET bindings for ROS2
Apache License 2.0
136 stars 54 forks source link

fix Timers not being invoked when using ActionClients or ActionServer within the same node #130

Closed hofmannmarkus0 closed 2 months ago

hofmannmarkus0 commented 2 months ago

currently when running a node that creates an ActionClient or ActionServer, creating a Timer in the same node will just not execute the timer callback at all as it tries to execute the timer at index 0, but ActionClient and ActionServer add their Timers to the WaitSet first.

hoffmann-stefan commented 2 months ago

@hofmannmarkus0 Thanks for the PR :)

This was some detail overseen when merging https://github.com/ros2-dotnet/ros2_dotnet/pull/124.

@Chootin This issue may be in your branches as well, you may want to cherry-pick before you get into the same issue :) Sent you an E-mail at your git commit e-mail for some informations that I don't want to share publicly. (For others, this has nothing directly to do with the project, otherwise I would have shared publicly)