search

ros2-dotnet / ros2_dotnet

.NET bindings for ROS2
Apache License 2.0
139 stars 57 forks source link

Add support for sequences/arrays of basic/primitive types (#1) #87

Closed ooeygui closed 1 year ago

ooeygui commented 2 years ago

Breaking up our large drop. This is support for arrays and primitive types

esteve commented 2 years ago

@ooeygui awesome! Thanks for breaking up the other PR, makes it so much easier to review.

ooeygui commented 2 years ago

Looking into the build failures

esteve commented 2 years ago

@ooeygui a priori changes look good, but I can't see the build logs. I'm going to approve this PR, but if you have time, it'd be great if you could fix the build issues before merging. Thanks!

esteve commented 2 years ago

@ooeygui how would you like to proceed here? Did you figure out what is causing the build issue? I created #86 to address the CI issues, but it seems colcon can't figure out the topological order of the packages.

ooeygui commented 2 years ago

Sorry for the delay (I've been heads down on getting the Foxy sync release stable on Windows).

hoffmann-stefan commented 1 year ago

Closing this PR as the features where implemented in https://github.com/ros2-dotnet/ros2_dotnet/pull/89 which is already merged.