ros2-gbp / ros2-gbp-github-org

ROS 2 Git Built Package (GBP) -- GitHub organization that hosts the release repositories for ROS packages. It also maintains a list of release teams, the list of members per release team.
13 stars 70 forks source link

Add new release repository picknik_controllers-release #283

Closed moriarty closed 1 year ago

moriarty commented 1 year ago

The https://github.com/ros/rosdistro/pull/37736 hasn't been merged yet but I'm opening this issue early assuming there are no naming issues.

nuclearsandwich commented 1 year ago

assuming there are no naming issues.

Opening the issue early is definitely welcome. I would still block release repository creation on approval of the REP-144 naming in particular since if they don't pass those review the release repository name is likely to change. In this case, I went ahead and did the source entry review as a prerequisite to approving this PR.

nuclearsandwich commented 1 year ago

In case I get lost today, the deployment of this PR was delayed because I hit the 5000 request rate limit after a few successive terraform plans. I should be updating within an hour confirming successful deployment but it's possible (given that it's Saturday) that time will get away from me while waiting.

nuclearsandwich commented 1 year ago

This change has been deployed!

tylerjw commented 1 year ago

picknik_controllers-release doesn't seem to exist as a repo, are we missing something?

moriarty commented 1 year ago

Hi @nuclearsandwich

I still don't see a https://github.com/ros2-gbp/picknik_controllers-release

Does adding the line in #284 automatically get deployed or automatically create the repository eventually? Or do we still need someone with permissions to manually create the release repository?

moriarty commented 1 year ago

Great, the repo was created today.

Thanks!