ros2-gbp / ros2-gbp-github-org

ROS 2 Git Built Package (GBP) -- GitHub organization that hosts the release repositories for ROS packages. It also maintains a list of release teams, the list of members per release team.
12 stars 67 forks source link

Add Kinova Robotics release team #291

Closed moriarty closed 1 year ago

moriarty commented 1 year ago

I am preparing to release a new repository and set of packages for ROS 2 that will be transferred to the kinovarobotics github organization.

Note, this is a ROS 2 re-implementation of an release of an existing ROS 1 repository.

Edit: has been open sourced under PickNikRobotics will transfer ownership after initial debian releases and support ~Unfortunately there repo is still private and ownership needs to be transferred before release. It is expected that this is finished within the next week.~

I am opening this issue to have the release team and release repository created now as we would like not have any delays. There are no new package names (minor typo move_it->moveit) other packages removed as we've been able to relay more on upstream ROS 2 Control.

nuclearsandwich commented 1 year ago

I am opening this issue to have the release team and release repository created now as we would like not have any delays. There are no new package names (minor typo move_it->moveit) other packages removed as we've been able to relay more on upstream ROS 2 Control.

I understand and appreciate the desire to be proactive. However, I don't find any occurrences (using git grep) of the terms kinova or kortex in ros/rosdistro which means that these package names have not been reviewed previously and thus I think they should go through the complete current process which means that the source entry should be added to ros/rosdistro in order to indicate that the repository and packages it contains have passed new package review.

In the meantime, I've opened #294 which will resolve this issue when the naming review is complete.

nuclearsandwich commented 1 year ago
  • @moriarty PickNik Robotics
  • @felixmaisonneuve Kinova Robotics
  • @martinleroux Kinova Robotics

When the source repository is public please update these to link with maintainer or author entries in the package source for transparency.

moriarty commented 1 year ago

@nuclearsandwich Thanks! sorry I didn't even realize ros_kortex had never been released via rosdistro.

There is combination long weekends and summer vacations Saint-Jean-Baptiste Day, then Canada Day and now Independence Day :upside_down_face: I was trying to get this finished and released before :sweat_smile:

moriarty commented 1 year ago
  • @moriarty PickNik Robotics
  • @felixmaisonneuve Kinova Robotics
  • @martinleroux Kinova Robotics

When the source repository is public please update these to link with maintainer or author entries in the package source for transparency.

@nuclearsandwich the repository is now public, and I've added links to the maintainers. also tagged them in the commit that referenced this issue.

So if you can create the ros_kortex-release repository that would be great.

There is still some missing dependencies that need to land before I can fully bloom and release all the packages...

nuclearsandwich commented 1 year ago

This change has been deployed!