search

ros2-gbp / ros2-gbp-github-org

ROS 2 Git Built Package (GBP) -- GitHub organization that hosts the release repositories for ROS packages. It also maintains a list of release teams, the list of members per release team.
9 stars 61 forks source link

Add release team for niwcpac #466

Closed xydesa closed 2 months ago

xydesa commented 4 months ago
denewiler commented 4 months ago

I have a rosdistro branch ready to go that adds a new package to rosdistro distribution.yaml files if we need to do that first.

https://github.com/ros/rosdistro/compare/master...tdenewiler:rosdistro:rqt-dotgraph

nuclearsandwich commented 4 months ago

@denewiler @xydesa before the release team is created, the PR to rosdistro which adds the source (and optionally doc) entries should be created so that the package can undergo license and naming review. The release stanza should be omitted from the manually created PR and added by using the bloom utility to create the release once the release repository is created.

Once the linked comparison has been opened as a PR and merged into ros/rosdistro please update this request.

xydesa commented 3 months ago

@nuclearsandwich Thanks for letting us know. FYI the ROS2 documentation makes it seem like we needed a release team first and the ticket template in here is ambiguous on that count. Which is why I made this PR first.

nuclearsandwich commented 3 months ago

FYI the ROS2 documentation makes it seem like we needed a release team first and the ticket template in here is ambiguous on that count. Which is why I made this PR first.

It's a bit labyrinthine but the documentation for Creating a release repository points out that "If your repository is new to the ROS community, you should first open a pull request on ros/rosdistro adding a source entry for your repository."

Building better tooling for this workflow (or optimizing it away) is definitely in my goals for the future.

xydesa commented 3 months ago

https://github.com/ros/rosdistro/pull/40169

has been merged. ticket description updated.

tdenewiler commented 2 months ago

I know you are busy working on the Jazzy release (and we are excited for that). Just adding a comment here to see if there is time to create this new release team. Thanks!

nuclearsandwich commented 2 months ago

This change has been deployed.

I know you are busy working on the Jazzy release (and we are excited for that). Just adding a comment here to see if there is time to create this new release team. Thanks!

Thanks for your patience and understanding!