search

ros2-gbp / vrpn-release

0 stars 3 forks source link

Upstream changes #1

Open Pleune opened 3 months ago

Pleune commented 3 months ago

I see that only the "deprecate CMAKE_HAVE_THREADS_LIBRARY" changes have been upstream. Could we do the same for others, such as installing the rest of the cmake files? I feel like it is strange to have changed in this repo that are not being accepted into the standard upstream.

alvinsunyixiao commented 3 months ago

This change is indeed in the upstream master (unstable) branch, but it hasn't made it into a stable release yet. The most recent release is 07.35 and it was released 2 years ago.

Pleune commented 3 months ago

I did see that the latest upstream release is very old, but many changes have been made since then.

However, even looking at the latest master of vrpn/vrpn, the additional install( ... ) sections at the very end of the root CMakeLists file are not added, and I do not see them pending in a PR. This is one of those commits for this repo: e5b4a5eed2d1496cd1ee9cc941199b6f7a045d5f

This is the specific change that exists only here, and it is one that I need to fix my local build (or I think anyone who would build something depending on the vrpn ros package).

alvinsunyixiao commented 3 months ago

The commits are patched through the 3rd party ROS package release process. The changes are there to make sure VRPN builds with colcon, but they will not go into the original VRPN repo.

"deprecate CMAKE_HAVE_THREADS_LIBRARY" was not pushed upstream from this repo into vrpn/vrpn. This change was first introduced last year in vrpn/vrpn, and then a few weeks ago, I cherrypicked this change into the rolling distribution to fix a build error in Ubuntu 24.04 due to higher CMAKE versions.