search

ros2-java / ros2_java

Java and Android bindings for ROS2
Apache License 2.0
172 stars 93 forks source link

Add interfaces for action goal, result, and feedback #142

Closed jacobperron closed 3 years ago

jacobperron commented 4 years ago

Implementing these interfaces in the code generation template makes it easier to pass around these types in a generic way. Note, the 'final' modifier had to be removed from generated message types in order to extend goal, result, and feedback types in action definitions.

ivanpauno commented 4 years ago

Implementing these interfaces in the code generation template makes it easier to pass around these types in a generic way. Note, the 'final' modifier had to be removed from generated message types in order to extend goal, result, and feedback types in action definitions.

I think both things are reasonable, but I'm not sure why they are needed. Maybe it's better to review this with the full context of how these changes are going to be used (?).

jacobperron commented 4 years ago

Maybe it's better to review this with the full context of how these changes are going to be used (?).

Sure, I can open another PR building on this for context. I figured I would try and make things as bit-sized as possible.

esteve commented 4 years ago

I agree with @ivanpauno , I'm missing the bigger picture, but if these changes make it easier to implement actions, go for it :-) Thanks!

jacobperron commented 3 years ago

Closing because this is stale.