search

ros2-java / ros2_java

Java and Android bindings for ROS2
Apache License 2.0
167 stars 92 forks source link

Update main branch: wide string encoding, spinAll() implementation in executors #191

Closed ivanpauno closed 2 years ago

ivanpauno commented 2 years ago

Cherry-picked:

I'm planning to rebase and merge this PR. I will continue opening similar PRs until getting the main branch completely updated.

ivanpauno commented 2 years ago

For the PRs forthcoming, it's probably good to add descriptive PR titles and update any ticket references in the commits to point to the original PR (e.g. if it's from the osrf fork, then make sure we're pointing there and not to a random ticket in this repo).

https://github.com/ros2-java/ros2_java/pull/118 is the correct PR, it's not a random ticket in this repo. For some reason that was applied to the jacob/foxy branch in this repo (which was removed) but it's not in main.

https://github.com/osrf/ros2_java/commit/ac9fec1ec01165a0446397fc0933e7482ccd6355 was pushed directly to osrf/galactic-devel and there's no PR linking to it (I have corrected the commit hashes though).

jacobperron commented 2 years ago

I had staged changes for Foxy on this repo originally, but then we moved development to a fork :shrug: