search

ros2 / cartographer_ros

Provides ROS integration for Cartographer.
Apache License 2.0
114 stars 59 forks source link

Fix pub/sub creation calls for eloquent APIs #37

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Update create_publisner/subscription APIs for eloquent. This repo won't build against lastest rclcpp

Not sure if this is the correct branch to pull against, let me know.

clalancette commented 4 years ago

The ros2 branch is retired now, in favor of the dashing branch (which is the style we use in ROS 1 packages as well). You can more-or-less tell this is the case by looking at https://github.com/ros/rosdistro/blob/d606d63b20e0f83244975b1822451ac149e4deb9/dashing/distribution.yaml#L316 ; while it isn't definitive for eloquent, it is suggestive.

In any case, the dashing branch seems to compile just fine against eloquent, so I'll close this out. Thanks!

emersonknapp commented 4 years ago

Thanks for the info! The default branch for the repo is ros2, so I landed there when I found this fork. Would it make sense to change that?

clalancette commented 4 years ago

Thanks for the info! The default branch for the repo is ros2, so I landed there when I found this fork. Would it make sense to change that?

Oops, I forgot to change that. Good call, I've fixed it now. Thanks!