ros2 / cartographer_ros

Provides ROS integration for Cartographer.
Apache License 2.0
121 stars 59 forks source link

Minor updates to the cartographer_ros build for Rolling #48

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

The main goal of this PR is to fix the build of cartographerros on Rolling. In particular, Rolling no longer allows using std::string for the RCLCPP macros, so fix that here. This is also backwards compatible to Foxy and Dashing.

While we were in here, I noticed a bunch of non-optimal setup for the CMakeLists.txt. Clean up some of this just to make it more ament-like.