search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
47 stars 30 forks source link

Connext security tests failing on Windows #488

Open jacobperron opened 4 years ago

jacobperron commented 4 years ago

For example: Build Status

In https://github.com/ros2/ci/pull/454, we updated our Windows CI to install OpenSSL 1.1.1, but ran into issues with tests using Connext in test_security. The tests were disabled in https://github.com/ros2/system_tests/pull/433. This is a follow-up ticket to track progress towards re-enabling those security tests.

Connext requires an EOL-version of OpenSSL (1.0.2g). A convention for selecting the version of OpenSSL was introduced in https://github.com/ros2/system_tests/pull/409, and used to fix the tests for macOS in https://github.com/ros2/ci/pull/436.

It's still not clear why the tests are failing on Windows CI. Locally, I do not have an issue running the tests.

dirk-thomas commented 4 years ago

See ros2/ci#488.

clalancette commented 2 years ago

I think that this has been long solved; at least, the latest nightlies show test_security passing on Windows: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2200/testReport/test_security/ .

As such, I'm going to close this out. If I'm wrong about this, please feel free to reopen.

nuclearsandwich commented 2 years ago

Actually, as I discovered when working on the connext 6 support (#614) these tests are not currently run for connext on Windows.

https://github.com/ros2/system_tests/blob/44ac714f2cd201b2a2c98949595e953d5a289191/test_security/CMakeLists.txt#L249-L262

I think we can update that conditional to run them for rmw_connextdds when rti-connext-dds >= 6.0.1