search

ros2 / ci

ROS 2 CI Infrastructure
http://ci.ros2.org/
Apache License 2.0
48 stars 30 forks source link

Change configuration for clang-libcxx jobs. #711

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

There are 2 changes:

  1. Make sure to force building vendor packages. That way all packages are built by clang and can be successfully linked.
  2. Skip the RQT packages. They are failing to build for reasons I don't quite understand, but skipping them is better than failing the build completely.

Leaving as a draft until I can get a yellow CI run with this in place.

clalancette commented 1 year ago

CI:

clalancette commented 1 year ago

All right, with one other fix (https://github.com/ros2/libyaml_vendor/pull/59), I was able to get the job to go from red to yellow. So I'll change this to a real PR, since we'll need both to get this fully fixed.

clalancette commented 1 year ago

Looks good to me, do we want to start tracking this job? I don't know how often it's run and/or if we want to include them as part of the developer PRs process. cc: @Crola1702 @claraberendsen

It's currently run nightly, and I think we can just leave it at that. For now, I don't think it is useful to track this job as it has so many warnings. Maybe if we get that cleaned up we can add it to the list to be tracked, but I don't have a timeline or that.